You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The streaming file download was failing when downloading the data connect emulator in CI only (reasons unknown). To fix the issue, we can download the file to a buffer (Uint8Array), then write it synchronously to disk.
We preferred the streaming approach because it meant we didn't have to store the entire emulator file in memory, but I found that this buffer approach uses roughly the same amount of memory (~195mB in total for the test process).
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v4.0
The reason will be displayed to describe this comment to others. Learn more.
There's a couple of other ways around this, I think, not 100% sure. One is to set like const self = this at the top level (outside of the fetch anyway) and then you call self.binaryPath when needed. That looks weird so another better looking option is that you create a function at the top level called setBinaryPath that is just like
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The streaming file download was failing when downloading the data connect emulator in CI only (reasons unknown). To fix the issue, we can download the file to a buffer (
Uint8Array), then write it synchronously to disk.We preferred the streaming approach because it meant we didn't have to store the entire emulator file in memory, but I found that this buffer approach uses roughly the same amount of memory (~195mB in total for the test process).